Core Committers#

The core committers team is reviewed approximately annually, new members are added based on quality contributions to SilverStipe code and outstanding community participation.

Core committer team#

House rules for the core committer team#

The "core committers" consist of everybody with write permissions to our codebase. With great power comes great responsibility, so we have agreed on certain expectations:

  • Be friendly, encouraging and constructive towards other community members
  • Frequently review pull requests and new issues (in particular, respond quickly to @mentions)
  • Treat issues according to our issue guidelines
  • Don't commit directly to core, raise pull requests instead (except trivial fixes)
  • Only merge code you have tested and fully understand. If in doubt, ask for a second opinion.
  • Ensure contributions have appropriate test coverage, are documented, and pass our coding conventions
  • Keep the codebase "releasable" at all times (check our release process)
  • API changes and non-trivial features should not be merged into release branches.
  • API changes on master should not be merged until they have the buy-in of at least two core committers (or better, through the core mailing list)
  • Be inclusive. Ensure a wide range of SilverStripe developers can obtain an understanding of your code and docs, and you're not the only one who can maintain it.
  • Avoid git push --force, and be careful with your git remotes (no accidental pushes)
  • Use your own forks to create feature branches
  • We release using the standard process. See the Making a SilverStripe Core Release